github-mirrors/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-21 14:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity
VictoriaMetrics/app/vmauth
History
Aliaksandr Valialkin 8295f7eb34
app/vmauth: simplify the logic for the fix at a0a154511a 
The fix at a0a154511a looks too complicated and fragile:

- It moves buMin initialization to the place, which is far from its usage.
- It embeds unclear logic on selecting the proper buMin if it is broken,
  into unrelated loop.

The actual fix must be more clear:

$ git diff 95acca6b52 -- app/vmauth/

-               if n := bu.concurrentRequests.Load(); n < minRequests {
+               if n := bu.concurrentRequests.Load(); n < minRequests || buMin.isBroken() {

This should simplify further maintenance of this code.

Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/7489
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3061
2024-11-14 17:21:30 +01:00
..
deployment all: suppress InvalidDefaultArgInFrom warning emitted by docker build when building Docker packages via make package-* command 2024-09-03 14:05:43 +02:00
multiarch app/*/multiarch: return back empty value for TARGETARCH 2024-09-06 18:15:22 +02:00
auth_config.go app/vmauth: simplify the logic for the fix at a0a154511a 2024-11-14 17:21:30 +01:00
auth_config_test.go app/vmauth: properly check for backend health before leastLoaded policy (#7489) 2024-11-08 17:07:54 +01:00
example_config.yml app/vmauth: adds metric_labels and backend_errors counter (#5585) 2024-01-22 01:09:51 +02:00
example_config_ent.yml vmauth: add browser authorization request for http requests without… (#5234) 2023-11-01 21:00:52 +01:00
main.go app/vmauth: change response code when all backend are not available (#6676) 2024-07-25 10:24:05 +02:00
main_test.go app/vmauth: verify how backend response headers are propagated to vmauth client 2024-07-27 13:45:07 +02:00
Makefile Add build support for loong64 (#6222) 2024-05-10 14:32:05 +02:00
README.md all: replace old https://docs.victoriametrics.com/vmauth.html url with the new one - https://docs.victoriametrics.com/vmauth/ 2024-04-18 01:50:16 +02:00
target_url.go app/vmauth: follow-up for b155b20de4 2024-04-17 14:53:20 +02:00
target_url_test.go app/vmauth: add missing tests for requestHandler() 2024-07-20 11:22:54 +02:00

README.md

See vmauth docs here.

vmauth docs can be edited at docs/vmauth.md.