VictoriaMetrics/lib/promrelabel
Aliaksandr Valialkin b24da0f901
Revert "lib/promrelabel: show error message if labels not in prometheus exposition format (#4304)"
This reverts commit 193a9c3328.

Reason for revert: the commit doesn't fix the real issue with promutils.NewLabelsFromString()
function, which must return error when improperly formatted Prometheus metric with labels is passed to it.
See https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#text-format-example

E.g. the promutils.NewLabelsFromString() must return error when the following strings are passed to it:

- `{foo:"bar"}`, since `:` is disallowed in Prometheus text exposition format. The corect value is `{foo="bar"}`
- `{"foo":"bar"}`, since label name shouldn't be quoted. The correct value is `{foo="bar"}`.

The reverted commit introduces another set of bugs, which happily accept the following invalid input:

- `{foo=~"bar"}`
- `{foo!="bar"}`
- `{foo!~"bar"}`

Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4284
See also https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4304
2023-05-12 17:01:23 -07:00
..
testdata lib/promrelabel: add support for keepequal and dropequal relabeling actions 2022-12-21 20:06:09 -08:00
config.go lib/promrelabel: add support for keepequal and dropequal relabeling actions 2022-12-21 20:06:09 -08:00
config_test.go lib/promrelabel: make fmt after d3de110070 2022-12-21 20:25:37 -08:00
debug.go Revert "lib/promrelabel: show error message if labels not in prometheus exposition format (#4304)" 2023-05-12 17:01:23 -07:00
debug.qtpl app/vmselect: small cleanup after 4f3f9950d0 2023-05-09 22:45:02 -07:00
debug.qtpl.go app/vmselect: small cleanup after 4f3f9950d0 2023-05-09 22:45:02 -07:00
graphite.go app,lib: fix typos in comments (#3804) 2023-02-13 09:32:35 -08:00
graphite_test.go lib/promrelabel: support action: graphite relabeling 2022-06-16 20:25:49 +03:00
graphite_timing_test.go lib/promrelabel: support action: graphite relabeling 2022-06-16 20:25:49 +03:00
if_expression.go lib/promrelabel: allow calling Match on nil IfExpression 2022-12-30 16:47:59 -08:00
if_expression_test.go lib/promscrape: implement target-level and metric-level relabel debugging 2022-12-10 02:25:56 -08:00
relabel.go lib/promrelabel: make target url from labels on target relabel page (#3882) 2023-03-20 22:08:39 -07:00
relabel_test.go lib/promrelabel: add support for keepequal and dropequal relabeling actions 2022-12-21 20:06:09 -08:00
relabel_timing_test.go lib/promscrape: implement target-level and metric-level relabel debugging 2022-12-10 02:25:56 -08:00
scrape_url.go lib/promrelabel: make target url from labels on target relabel page (#3882) 2023-03-20 22:08:39 -07:00
scrape_url_test.go lib/promrelabel: make target url from labels on target relabel page (#3882) 2023-03-20 22:08:39 -07:00