mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-01 14:47:38 +00:00
61d794c5e7
Use metricsql.IsLikelyInvalid() function for determining whether the given query is likely invalid, e.g. there is high change the query is incorrectly written, so it will return unexpected results. The query is invalid most of the time if it passes something other than series selector into rollup function. For example: - rate(sum(foo)) - rate(foo + bar) - rate(foo > bar) Improtant note: the query is considered valid if it misses the lookbehind window in square brackes inside rollup function, e.g. rate(foo), since this is very convenient MetricsQL extention to PromQL, and this query returns the expected results most of the time. Other unsafe query types can be added in the future into metricsql.IsLikelyInvalid(). TODO: probably, the -search.disableImplicitConversion command-line flag must be set by default in the future releases of VictoriaMetrics. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4338 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6180 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6450 |
||
|---|---|---|
| .. | ||
| active_queries.go | ||
| aggr.go | ||
| aggr_incremental.go | ||
| aggr_incremental_test.go | ||
| aggr_test.go | ||
| binary_op.go | ||
| eval.go | ||
| eval_test.go | ||
| exec.go | ||
| exec_test.go | ||
| memory_limiter.go | ||
| memory_limiter_test.go | ||
| parser.go | ||
| rollup.go | ||
| rollup_result_cache.go | ||
| rollup_result_cache_test.go | ||
| rollup_test.go | ||
| rollup_timing_test.go | ||
| timeseries.go | ||
| timeseries_test.go | ||
| transform.go | ||
| transform_test.go | ||
| tzdata.go | ||