VictoriaMetrics/app
Roman Khavronenko 83a4865a45
vmalert: always re-evaluate Annotations (#3119)
* vmalert: always re-evaluate Annotations

Previously, Annotations were evaluated only:
1. On alert creating.
2. On alert's value change.

This is premature optimization. It was assumed that since annotations
could contain only text with alert's labels or value - there is no need
in spending resources to re-compile Annotations.

Later, template function `query` was added, which can execute
arbitrary queries and return different results on every evaluation.
So if it was used in annotations, it would be executed only on init
or value change.

Another case when optimization caused an issue - annotations hot reload.
In this case, annotations of the active alert won't change even if Rule's
annotations were changed.

This fix enables Annotations re-evaluation on each iteration to resolve
issues above. It would have some impact on performance, but it is unlikely
it will be noticeable.

Signed-off-by: hagen1778 <roman@victoriametrics.com>

* vmalert: add tp Changelog

Signed-off-by: hagen1778 <roman@victoriametrics.com>

Signed-off-by: hagen1778 <roman@victoriametrics.com>
2022-10-06 16:03:06 +03:00
..
vmagent vmagent: expose metric vmagent_remotewrite_queues (#2871) (#3087) 2022-09-08 21:04:12 +03:00
vmalert vmalert: always re-evaluate Annotations (#3119) 2022-10-06 16:03:06 +03:00
vmauth app/vmauth: do not remove trailing slash from the proxied path 2022-10-06 15:28:58 +03:00
vmbackup app: fix make publish-* after ed93330e66 2022-07-14 11:01:34 +03:00
vmbackupmanager docs: update -help output for vmbackup, vmbackupmanager, vmgateway and vmrestore components 2022-06-21 15:49:26 +03:00
vmctl app: fix make publish-* after ed93330e66 2022-07-14 11:01:34 +03:00
vmgateway docs: update -help output for vmbackup, vmbackupmanager, vmgateway and vmrestore components 2022-06-21 15:49:26 +03:00
vminsert app: fix make publish-* after ed93330e66 2022-07-14 11:01:34 +03:00
vmrestore app: fix make publish-* after ed93330e66 2022-07-14 11:01:34 +03:00
vmselect vmui: fix data processing (#3092) 2022-10-06 15:57:22 +03:00
vmstorage app: fix make publish-* after ed93330e66 2022-07-14 11:01:34 +03:00
vmui vmui: fix data processing (#3092) 2022-10-06 15:57:22 +03:00