mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-21 14:44:00 +00:00
0be5b09fb4
* app/vmalert: extend metrics set exported by `vmalert` #573 New metrics were added to improve observability: + vmalert_alerts_pending{alertname, group} - number of pending alerts per group per alert; + vmalert_alerts_acitve{alertname, group} - number of active alerts per group per alert; + vmalert_alerts_error{alertname, group} - is 1 if alertname ended up with error during prev execution, is 0 if no errors happened; + vmalert_recording_rules_error{recording, group} - is 1 if recording rule ended up with error during prev execution, is 0 if no errors happened; * vmalert_iteration_total{group, file} - now contains group and file name labels. This should improve control over specific groups; * vmalert_iteration_duration_seconds{group, file} - now contains group and file name labels. This should improve control over specific groups; Some collisions for alerts and recording rules are possible, because neither group name nor alert/recording rule name are unique for compatibility reasons. Commit contains list of TODOs for Unregistering metrics since groups and rules are ephemeral and could be removed without application restart. In order to unlock Unregistering feature corresponding PR was filed - https://github.com/VictoriaMetrics/metrics/pull/13 * app/vmalert: extend metrics set exported by `vmalert` #573 The changes are following: * add an ID label to rules metrics, since `name` collisions within one group is a common case - see the k8s example alerts; * supports metrics unregistering on rule updates. Consider the case when one rule was added or removed from the group, or the whole group was added or removed. The change depends on https://github.com/VictoriaMetrics/metrics/pull/16 where race condition for Unregister method was fixed.
39 lines
633 B
Go
39 lines
633 B
Go
package main
|
|
|
|
import "github.com/VictoriaMetrics/metrics"
|
|
|
|
type gauge struct {
|
|
name string
|
|
*metrics.Gauge
|
|
}
|
|
|
|
func getOrCreateGauge(name string, f func() float64) *gauge {
|
|
return &gauge{
|
|
name: name,
|
|
Gauge: metrics.GetOrCreateGauge(name, f),
|
|
}
|
|
}
|
|
|
|
type counter struct {
|
|
name string
|
|
*metrics.Counter
|
|
}
|
|
|
|
func getOrCreateCounter(name string) *counter {
|
|
return &counter{
|
|
name: name,
|
|
Counter: metrics.GetOrCreateCounter(name),
|
|
}
|
|
}
|
|
|
|
type summary struct {
|
|
name string
|
|
*metrics.Summary
|
|
}
|
|
|
|
func getOrCreateSummary(name string) *summary {
|
|
return &summary{
|
|
name: name,
|
|
Summary: metrics.GetOrCreateSummary(name),
|
|
}
|
|
}
|