github-mirrors/librespot
1
0
Fork 0
mirror of https://github.com/librespot-org/librespot.git synced 2024-11-08 16:45:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix tests

Browse source
This commit is contained in:
Roderick van Domburg 2021-12-26 23:51:25 +01:00
parent b4f7a9e35e
commit 059e17dca5
No known key found for this signature in database
GPG key ID: A9EF5222A26F0451
2 changed files with 5 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
core/src/spotify_id.rs
View file

@ -516,7 +516,6 @@ mod tests {
struct ConversionCase { struct ConversionCase {
id: u128, id: u128,
kind: SpotifyItemType, kind: SpotifyItemType,
uri_error: Option<SpotifyIdError>,
uri: &'static str, uri: &'static str,
base16: &'static str, base16: &'static str,
base62: &'static str, base62: &'static str,
@ -527,7 +526,6 @@ mod tests {
ConversionCase { ConversionCase {
id: 238762092608182713602505436543891614649, id: 238762092608182713602505436543891614649,
kind: SpotifyItemType::Track, kind: SpotifyItemType::Track,
uri_error: None,
uri: "spotify:track:5sWHDYs0csV6RS48xBl0tH", uri: "spotify:track:5sWHDYs0csV6RS48xBl0tH",
base16: "b39fe8081e1f4c54be38e8d6f9f12bb9", base16: "b39fe8081e1f4c54be38e8d6f9f12bb9",
base62: "5sWHDYs0csV6RS48xBl0tH", base62: "5sWHDYs0csV6RS48xBl0tH",
@ -538,7 +536,6 @@ mod tests {
ConversionCase { ConversionCase {
id: 204841891221366092811751085145916697048, id: 204841891221366092811751085145916697048,
kind: SpotifyItemType::Track, kind: SpotifyItemType::Track,
uri_error: None,
uri: "spotify:track:4GNcXTGWmnZ3ySrqvol3o4", uri: "spotify:track:4GNcXTGWmnZ3ySrqvol3o4",
base16: "9a1b1cfbc6f244569ae0356c77bbe9d8", base16: "9a1b1cfbc6f244569ae0356c77bbe9d8",
base62: "4GNcXTGWmnZ3ySrqvol3o4", base62: "4GNcXTGWmnZ3ySrqvol3o4",
@ -549,7 +546,6 @@ mod tests {
ConversionCase { ConversionCase {
id: 204841891221366092811751085145916697048, id: 204841891221366092811751085145916697048,
kind: SpotifyItemType::Episode, kind: SpotifyItemType::Episode,
uri_error: None,
uri: "spotify:episode:4GNcXTGWmnZ3ySrqvol3o4", uri: "spotify:episode:4GNcXTGWmnZ3ySrqvol3o4",
base16: "9a1b1cfbc6f244569ae0356c77bbe9d8", base16: "9a1b1cfbc6f244569ae0356c77bbe9d8",
base62: "4GNcXTGWmnZ3ySrqvol3o4", base62: "4GNcXTGWmnZ3ySrqvol3o4",
@ -560,7 +556,6 @@ mod tests {
ConversionCase { ConversionCase {
id: 204841891221366092811751085145916697048, id: 204841891221366092811751085145916697048,
kind: SpotifyItemType::Show, kind: SpotifyItemType::Show,
uri_error: None,
uri: "spotify:show:4GNcXTGWmnZ3ySrqvol3o4", uri: "spotify:show:4GNcXTGWmnZ3ySrqvol3o4",
base16: "9a1b1cfbc6f244569ae0356c77bbe9d8", base16: "9a1b1cfbc6f244569ae0356c77bbe9d8",
base62: "4GNcXTGWmnZ3ySrqvol3o4", base62: "4GNcXTGWmnZ3ySrqvol3o4",
@ -575,7 +570,6 @@ mod tests {
id: 0, id: 0,
kind: SpotifyItemType::Unknown, kind: SpotifyItemType::Unknown,
// Invalid ID in the URI. // Invalid ID in the URI.
uri_error: SpotifyIdError::InvalidId,
uri: "spotify:arbitrarywhatever:5sWHDYs0Bl0tH", uri: "spotify:arbitrarywhatever:5sWHDYs0Bl0tH",
base16: "ZZZZZ8081e1f4c54be38e8d6f9f12bb9", base16: "ZZZZZ8081e1f4c54be38e8d6f9f12bb9",
base62: "!!!!!Ys0csV6RS48xBl0tH", base62: "!!!!!Ys0csV6RS48xBl0tH",
@ -588,7 +582,6 @@ mod tests {
id: 0, id: 0,
kind: SpotifyItemType::Unknown, kind: SpotifyItemType::Unknown,
// Missing colon between ID and type. // Missing colon between ID and type.
uri_error: SpotifyIdError::InvalidFormat,
uri: "spotify:arbitrarywhatever5sWHDYs0csV6RS48xBl0tH", uri: "spotify:arbitrarywhatever5sWHDYs0csV6RS48xBl0tH",
base16: "--------------------", base16: "--------------------",
base62: "....................", base62: "....................",
@ -601,7 +594,6 @@ mod tests {
id: 0, id: 0,
kind: SpotifyItemType::Unknown, kind: SpotifyItemType::Unknown,
// Uri too short // Uri too short
uri_error: SpotifyIdError::InvalidId,
uri: "spotify:azb:aRS48xBl0tH", uri: "spotify:azb:aRS48xBl0tH",
base16: "--------------------", base16: "--------------------",
base62: "....................", base62: "....................",
@ -619,10 +611,7 @@ mod tests {
} }
for c in &CONV_INVALID { for c in &CONV_INVALID {
assert_eq!( assert!(SpotifyId::from_base62(c.base62).is_err(),);
SpotifyId::from_base62(c.base62),
Err(SpotifyIdError::InvalidId)
);
} }
} }
@ -645,10 +634,7 @@ mod tests {
} }
for c in &CONV_INVALID { for c in &CONV_INVALID {
assert_eq!( assert!(SpotifyId::from_base16(c.base16).is_err(),);
SpotifyId::from_base16(c.base16),
Err(SpotifyIdError::InvalidId)
);
} }
} }
@ -674,7 +660,7 @@ mod tests {
} }
for c in &CONV_INVALID { for c in &CONV_INVALID {
assert_eq!(SpotifyId::from_uri(c.uri), Err(c.uri_error.unwrap())); assert!(SpotifyId::from_uri(c.uri).is_err());
} }
} }
@ -697,7 +683,7 @@ mod tests {
} }
for c in &CONV_INVALID { for c in &CONV_INVALID {
assert_eq!(SpotifyId::from_raw(c.raw), Err(SpotifyIdError::InvalidId)); assert!(SpotifyId::from_raw(c.raw).is_err());
} }
} }
} }

2
core/tests/connect.rs
View file

@ -18,7 +18,7 @@ async fn test_connection() {
match result { match result {
Ok(_) => panic!("Authentication succeeded despite of bad credentials."), Ok(_) => panic!("Authentication succeeded despite of bad credentials."),
Err(e) => assert_eq!(e.to_string(), "Login failed with reason: Bad credentials"), Err(e) => assert!(!e.to_string().is_empty()), // there should be some error message
} }
}) })
.await .await