removes homething devicetype (#1471)

* removes homething devicetype

fixes #1470

From the comments about "homething" support in spotify:
"Did they ever release their homething product? I assumed not and guess they removed all support for it. We could just remove this footgun."

* mention breaking homething change in Changelog

CHANGELOG.md

@@ -49,6 +49,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Removed
 
 - [core] Removed `get_canvases` from SpClient (breaking)
+- [core] DeviceType `homething` removed due to crashes on Android (breaking)
 - [metadata] Removed `genres` from Album (breaking)
 - [metadata] Removed `genre` from Artists (breaking)
 

core/src/config.rs

@@ -79,7 +79,6 @@ pub enum DeviceType {
     UnknownSpotify = 100,
     CarThing = 101,
     Observer = 102,
-    HomeThing = 103,
 }
 
 impl FromStr for DeviceType {
@@ -102,7 +101,6 @@ impl FromStr for DeviceType {
             "smartwatch" => Ok(Smartwatch),
             "chromebook" => Ok(Chromebook),
             "carthing" => Ok(CarThing),
-            "homething" => Ok(HomeThing),
             _ => Err(()),
         }
     }
@@ -130,7 +128,6 @@ impl From<&DeviceType> for &str {
             UnknownSpotify => "UnknownSpotify",
             CarThing => "CarThing",
             Observer => "Observer",
-            HomeThing => "HomeThing",
         }
     }
 }
@@ -169,7 +166,6 @@ impl From<DeviceType> for ProtoDeviceType {
             DeviceType::UnknownSpotify => ProtoDeviceType::UNKNOWN_SPOTIFY,
             DeviceType::CarThing => ProtoDeviceType::CAR_THING,
             DeviceType::Observer => ProtoDeviceType::OBSERVER,
-            DeviceType::HomeThing => ProtoDeviceType::HOME_THING,
         }
     }
 }

src/main.rs

@@ -1471,7 +1471,7 @@ fn get_setup() -> Setup {
                         speaker, tv, avr, stb, audiodongle, \
                         gameconsole, castaudio, castvideo, \
                         automobile, smartwatch, chromebook, \
-                        carthing, homething",
+                        carthing",
                         DeviceType::default().into(),
                     );