From 4370258716e3e3303b9242cda4ec894c80c0c31e Mon Sep 17 00:00:00 2001
From: JasonLG1979 <jasonlevigray3@gmail.com>
Date: Fri, 3 Dec 2021 11:47:51 -0600
Subject: [PATCH] Address clippy lint warnings for rust 1.57

---
 connect/src/context.rs                  | 2 ++
 core/src/connection/codec.rs            | 3 +--
 playback/src/audio_backend/jackaudio.rs | 9 +++------
 playback/src/audio_backend/mod.rs       | 2 +-
 playback/src/audio_backend/rodio.rs     | 1 +
 playback/src/mixer/alsamixer.rs         | 1 +
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/connect/src/context.rs b/connect/src/context.rs
index 63a2aebb..154d9507 100644
--- a/connect/src/context.rs
+++ b/connect/src/context.rs
@@ -46,6 +46,7 @@ pub struct TrackContext {
     // pub metadata: MetadataContext,
 }
 
+#[allow(dead_code)]
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
 pub struct ArtistContext {
@@ -54,6 +55,7 @@ pub struct ArtistContext {
     image_uri: String,
 }
 
+#[allow(dead_code)]
 #[derive(Deserialize, Debug)]
 pub struct MetadataContext {
     album_title: String,
diff --git a/core/src/connection/codec.rs b/core/src/connection/codec.rs
index 299220f6..86533aaf 100644
--- a/core/src/connection/codec.rs
+++ b/core/src/connection/codec.rs
@@ -87,8 +87,7 @@ impl Decoder for ApCodec {
 
                 let mut payload = buf.split_to(size + MAC_SIZE);
 
-                self.decode_cipher
-                    .decrypt(&mut payload.get_mut(..size).unwrap());
+                self.decode_cipher.decrypt(payload.get_mut(..size).unwrap());
                 let mac = payload.split_off(size);
                 self.decode_cipher.check_mac(mac.as_ref())?;
 
diff --git a/playback/src/audio_backend/jackaudio.rs b/playback/src/audio_backend/jackaudio.rs
index 5ba7b7ff..15acf99d 100644
--- a/playback/src/audio_backend/jackaudio.rs
+++ b/playback/src/audio_backend/jackaudio.rs
@@ -24,15 +24,12 @@ pub struct JackData {
 impl ProcessHandler for JackData {
     fn process(&mut self, _: &Client, ps: &ProcessScope) -> Control {
         // get output port buffers
-        let mut out_r = self.port_r.as_mut_slice(ps);
-        let mut out_l = self.port_l.as_mut_slice(ps);
-        let buf_r: &mut [f32] = &mut out_r;
-        let buf_l: &mut [f32] = &mut out_l;
+        let buf_r: &mut [f32] = self.port_r.as_mut_slice(ps);
+        let buf_l: &mut [f32] = self.port_l.as_mut_slice(ps);
         // get queue iterator
         let mut queue_iter = self.rec.try_iter();
 
-        let buf_size = buf_r.len();
-        for i in 0..buf_size {
+        for i in 0..buf_r.len() {
             buf_r[i] = queue_iter.next().unwrap_or(0.0);
             buf_l[i] = queue_iter.next().unwrap_or(0.0);
         }
diff --git a/playback/src/audio_backend/mod.rs b/playback/src/audio_backend/mod.rs
index 4d3b0171..dc21fb3d 100644
--- a/playback/src/audio_backend/mod.rs
+++ b/playback/src/audio_backend/mod.rs
@@ -104,7 +104,7 @@ use self::gstreamer::GstreamerSink;
 
 #[cfg(any(feature = "rodio-backend", feature = "rodiojack-backend"))]
 mod rodio;
-#[cfg(any(feature = "rodio-backend", feature = "rodiojack-backend"))]
+#[cfg(feature = "rodio-backend")]
 use self::rodio::RodioSink;
 
 #[cfg(feature = "sdl-backend")]
diff --git a/playback/src/audio_backend/rodio.rs b/playback/src/audio_backend/rodio.rs
index 200c9fc4..ab356d67 100644
--- a/playback/src/audio_backend/rodio.rs
+++ b/playback/src/audio_backend/rodio.rs
@@ -227,5 +227,6 @@ impl Sink for RodioSink {
 }
 
 impl RodioSink {
+    #[allow(dead_code)]
     pub const NAME: &'static str = "rodio";
 }
diff --git a/playback/src/mixer/alsamixer.rs b/playback/src/mixer/alsamixer.rs
index 81d0436f..55398cb7 100644
--- a/playback/src/mixer/alsamixer.rs
+++ b/playback/src/mixer/alsamixer.rs
@@ -10,6 +10,7 @@ use alsa::{Ctl, Round};
 use std::ffi::CString;
 
 #[derive(Clone)]
+#[allow(dead_code)]
 pub struct AlsaMixer {
     config: MixerConfig,
     min: i64,