From 528a8a431e9b46b32fe308855ddd0dd0ef07df10 Mon Sep 17 00:00:00 2001 From: JasonLG1979 <jasonlevigray3@gmail.com> Date: Sat, 24 Jun 2023 22:36:33 -0500 Subject: [PATCH] Don't pad the alsa buffer anymore on stop. It's no longer necessary with the SymphoniaDecoder, in fact it causes the problem it used to prevent. Namely pops when you pause. --- playback/src/audio_backend/alsa.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/playback/src/audio_backend/alsa.rs b/playback/src/audio_backend/alsa.rs index 9a8721e0..e5c311c7 100644 --- a/playback/src/audio_backend/alsa.rs +++ b/playback/src/audio_backend/alsa.rs @@ -246,9 +246,6 @@ impl Sink for AlsaSink { } fn stop(&mut self) -> SinkResult<()> { - // Zero fill the remainder of the period buffer and - // write any leftover data before draining the actual PCM buffer. - self.period_buffer.resize(self.period_buffer.capacity(), 0); self.write_buf()?; if let Some(pcm) = self.pcm.take() {