From 9e06b11609cad6fe1987f6e5a4647c58b823e291 Mon Sep 17 00:00:00 2001 From: Roderick van Domburg Date: Thu, 28 Jul 2022 19:32:11 +0200 Subject: [PATCH] Update MSRV to 1.61 and fix test --- .github/workflows/test.yml | 6 +++--- COMPILING.md | 2 +- core/tests/connect.rs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 54366092..caa2722a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -55,7 +55,7 @@ jobs: matrix: os: [ubuntu-latest] toolchain: - - "1.60" # MSRV (Minimum supported rust version) + - "1.61" # MSRV (Minimum supported rust version) - stable experimental: [false] # Ignore failures in beta @@ -113,7 +113,7 @@ jobs: matrix: os: [windows-latest] toolchain: - - "1.60" # MSRV (Minimum supported rust version) + - "1.61" # MSRV (Minimum supported rust version) - stable steps: - name: Checkout code @@ -160,7 +160,7 @@ jobs: os: [ubuntu-latest] target: [armv7-unknown-linux-gnueabihf] toolchain: - - "1.60" # MSRV (Minimum supported rust version) + - "1.61" # MSRV (Minimum supported rust version) - stable steps: - name: Checkout code diff --git a/COMPILING.md b/COMPILING.md index ec1d174e..527be464 100644 --- a/COMPILING.md +++ b/COMPILING.md @@ -7,7 +7,7 @@ In order to compile librespot, you will first need to set up a suitable Rust bui ### Install Rust The easiest, and recommended way to get Rust is to use [rustup](https://rustup.rs). Once that’s installed, Rust's standard tools should be set up and ready to use. -*Note: The current minimum supported Rust version at the time of writing is 1.60.* +*Note: The current minimum supported Rust version at the time of writing is 1.61.* #### Additional Rust tools - `rustfmt` To ensure a consistent codebase, we utilise [`rustfmt`](https://github.com/rust-lang/rustfmt) and [`clippy`](https://github.com/rust-lang/rust-clippy), which are installed by default with `rustup` these days, else they can be installed manually with: diff --git a/core/tests/connect.rs b/core/tests/connect.rs index 9411bc87..91679f91 100644 --- a/core/tests/connect.rs +++ b/core/tests/connect.rs @@ -7,8 +7,8 @@ use librespot_core::{authentication::Credentials, config::SessionConfig, session #[tokio::test] async fn test_connection() { timeout(Duration::from_secs(30), async { - let result = Session::new(SessionConfig::default(), None, false) - .connect(Credentials::with_password("test", "test")) + let result = Session::new(SessionConfig::default(), None) + .connect(Credentials::with_password("test", "test"), false) .await; match result {