github-mirrors/librespot
1
0
Fork 0
mirror of https://github.com/librespot-org/librespot.git synced 2024-12-18 17:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

Tweak handling unavailables at start of playlists

Browse source
This commit is contained in:
ashthespy 2020-05-27 18:14:31 +02:00
parent 1da80ce480
commit a28199f073
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
connect/src/spirc.rs
View file

@ -914,13 +914,19 @@ impl SpircTask {
// Mark unavailable tracks so we can skip them later // Mark unavailable tracks so we can skip them later
fn handle_unavailable(&mut self, track_id: SpotifyId) { fn handle_unavailable(&mut self, track_id: SpotifyId) {
let playing_index = self.state.get_playing_track_index() as usize; let playing_index = self.state.get_playing_track_index() as usize;
let search_from = if playing_index == self.state.get_track().len() - 1 { let mut unavailables = self.get_track_index_for_spotify_id(&track_id, playing_index);
trace!("Cycling back to 0 instead of {:?}", playing_index); if unavailables.is_empty() {
0 trace!(
} else { "Couldn't find unavailables searching from {:?} -- {:?}, cycling through entire playlist",
playing_index playing_index,
}; self.state.get_track().len()
let unavailables = self.get_track_index_for_spotify_id(&track_id, search_from); );
// We could just do this everytime, but for most cases it's needless overhead.
// we are still repeating the serach for (playing_index..) in this case
unavailables = self.get_track_index_for_spotify_id(&track_id, 0);
}
// Sanity check
debug_assert!(!unavailables.is_empty());
for &index in unavailables.iter() { for &index in unavailables.iter() {
debug_assert_eq!(self.state.get_track()[index].get_gid(), track_id.to_raw()); debug_assert_eq!(self.state.get_track()[index].get_gid(), track_id.to_raw());
let mut unplayable_track_ref = TrackRef::new(); let mut unplayable_track_ref = TrackRef::new();
@ -1185,8 +1191,6 @@ impl SpircTask {
.filter(|&(_, track_ref)| track_ref.get_gid() == track_id.to_raw()) .filter(|&(_, track_ref)| track_ref.get_gid() == track_id.to_raw())
.map(|(idx, _)| start_index + idx) .map(|(idx, _)| start_index + idx)
.collect(); .collect();
// Sanity check
debug_assert!(!index.is_empty());
index index
} }