From fe644bc0d7bf8fb92c256965f24a9aa3253840a1 Mon Sep 17 00:00:00 2001 From: Roderick van Domburg Date: Thu, 2 Sep 2021 22:04:30 +0200 Subject: [PATCH] Update default normalisation threshold --- CHANGELOG.md | 1 + playback/src/config.rs | 2 +- src/main.rs | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index acf4f735..834b0bbf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [playback] `alsamixer`: use `--device` name for `--mixer-card` unless specified otherwise - [playback] `player`: consider errors in `sink.start`, `sink.stop` and `sink.write` fatal and `exit(1)` (breaking) - [playback] `player`: make `convert` and `decoder` public so you can implement your own `Sink` +- [playback] Updated default normalisation threshold to -2 dBFS ### Deprecated - [connect] The `discovery` module was deprecated in favor of the `librespot-discovery` crate diff --git a/playback/src/config.rs b/playback/src/config.rs index 7604f59f..14c9cf38 100644 --- a/playback/src/config.rs +++ b/playback/src/config.rs @@ -151,7 +151,7 @@ impl Default for PlayerConfig { normalisation_type: NormalisationType::default(), normalisation_method: NormalisationMethod::default(), normalisation_pregain: 0.0, - normalisation_threshold: db_to_ratio(-1.0), + normalisation_threshold: db_to_ratio(-2.0), normalisation_attack: Duration::from_millis(5), normalisation_release: Duration::from_millis(100), normalisation_knee: 1.0, diff --git a/src/main.rs b/src/main.rs index d240e224..c896a303 100644 --- a/src/main.rs +++ b/src/main.rs @@ -371,7 +371,7 @@ fn get_setup(args: &[String]) -> Setup { .optopt( "", NORMALISATION_THRESHOLD, - "Threshold (dBFS) to prevent clipping. Defaults to -1.0.", + "Threshold (dBFS) to prevent clipping. Defaults to -2.0.", "THRESHOLD", ) .optopt(