Commit graph

1972 commits

Author SHA1 Message Date
Roderick van Domburg 8941495b80
Merge pull request #1091 from librespot-org/dependabot/cargo/tokio-1.23.1
Bump tokio from 1.21.2 to 1.23.1
2023-01-07 14:00:28 +01:00
dependabot[bot] 64603f651e
Bump tokio from 1.21.2 to 1.23.1
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.21.2 to 1.23.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.21.2...tokio-1.23.1)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-06 21:47:45 +00:00
Lukáš Tyrychtr 14ace17967
Update sysinfo, fixing a future incompatibility warning (#1090) 2023-01-04 20:39:30 +01:00
Roderick van Domburg 7a01a3e442
Merge pull request #1089 from GeorgeHahn/microsecond-timestamps
Handle microsecond timestamps
2023-01-04 20:37:56 +01:00
Roderick van Domburg 61ae66b998
Merge pull request #1088 from GeorgeHahn/support-named-playlist-ids
Parse playlist URIs with named IDs
2023-01-04 20:36:16 +01:00
Roderick van Domburg c14c22a5ef
Merge pull request #1084 from gdesmott/lyrics
[dev] core: spclient: parse lyrics
2023-01-04 20:25:26 +01:00
George Hahn ce4be71719 fix timestamp heuristic (year 2200+) 2023-01-03 22:39:07 -07:00
George Hahn c2c31247b5 changelog 2023-01-03 22:28:36 -07:00
George Hahn 512c799266 Handle microsecond timestamps 2023-01-03 22:26:58 -07:00
Guillaume Desmottes 7f2cb684c9 fix clippy warnings 2023-01-03 00:36:35 +01:00
George Hahn 7a259ccc4b Parse named ID URIs 2023-01-02 16:27:40 -07:00
Guillaume Desmottes f72048e5e1 metadata: add lyrics
Save users from doing all the parsing themselves.
2023-01-02 19:00:10 +01:00
Oliver Cooper edf646d4bb
Add activate and load functions to Spirc (#1075) 2022-12-03 12:25:27 +01:00
Roderick van Domburg 98c985ffab
Merge pull request #1079 from ealasu/feature/local-spotify-id
Fix bug where playlists containing a local track would fail to load
2022-12-03 08:47:13 +01:00
ealasu 7d00881dcd Fix build error due to GitHub Actions updating to Ubuntu 22.04
https://github.com/actions/runner-images/issues/6399#issuecomment-1286050292
2022-12-02 17:38:39 -07:00
ealasu 5cfdb8c9dd Parse local file IDs 2022-12-02 17:24:02 -07:00
setime bf7cbbaadd
Add an option to specify IPs that zeroconf will bind to (#1071)
* added an option to specify ip addresses to which mDNS should bind (ignored by `DNS-SD`)
* changed command line option to `zeroconf-interface` to be consistent with `zeroconf-port`
use builder pattern to DRY up the code
used macro to print warning message
* fixing register error
* renamed `bind_ip` variables to match the option to `zeroconf_ip`, to be more consistent
* Changed user help
Modified comments
Added block for condition to clean the code
Added new modification to the change log

Co-authored-by: setime <timeframe1@gmx.de>
2022-11-25 09:57:14 +01:00
Roderick van Domburg b0db6502b5
Merge pull request #1076 from kingosticks/fix-latest-clippy
Fix latest clippy warnings
2022-11-24 12:43:15 +01:00
Nick Steel 68bbb4fbbc Fix latest clippy and fmt warnings 2022-11-22 13:38:02 +00:00
Roderick van Domburg 2c20669a5c
Merge pull request #1070 from wholivesinapineappleunderthesea/dev
Fix play track item_type in the examples folder
2022-11-04 07:58:11 +01:00
killahtree b15490714d
Update play.rs 2022-11-03 20:21:39 -04:00
killahtree 39b37d344f
Update play.rs 2022-11-03 20:10:49 -04:00
Roderick van Domburg b1e1e61a94
Merge pull request #1066 from gdesmott/send-workaround
core: workaround for Session::connect() future being !Send
2022-10-26 22:20:33 +02:00
Guillaume Desmottes 1a48bc87c8 core: workaround for Session::connect() future being !Send
rsa::padding::PaddingScheme is !Send, making it impossible to call
Session::connect() with an executor requiring Send futures, such as
Rocket.

Fix #1065
2022-10-20 17:22:00 +02:00
Roderick van Domburg 29ec49b74c
Merge pull request #1062 from JasonLG1979/fix-fmt-lint
Fix fmt lint
2022-10-02 11:06:05 +02:00
JasonLG1979 ce9eb42469 Fix fmt lint from 05dcb652a0 2022-10-01 19:51:55 -05:00
Roderick van Domburg 05dcb652a0
Fix example 2022-10-02 00:08:36 +02:00
Roderick van Domburg bae304fdb0
Update zeroconf fields and publish active user 2022-10-02 00:00:30 +02:00
Roderick van Domburg f10b8f69f8
Improvements towards supporting pagination
Not there yet, as Apollo stations always return autoplay
recommendations even if you set autoplay to false. Along the way
as an effort to bring the protocol up to spec:

- And support for and use different Apollo station scopes depending
  on whether we are using autoplay or not. For autoplay, get a
  "stations" scope and follow the "tracks" pages from there. Otherwise
  use "tracks" immediately for the active scope (playlist, album).

- For the above point we only need the fields from `PageContext`
  so use that instead of a `StationContext`.

- Add some documentation from API reverse engineering: things seen
  in the wild, some of them to do, others documented for posterity's
  sake.

- Update the Spirc device state based on what the latest desktop
  client puts out. Unfortunately none of it seems to change the
  behavior necessary to support external episodes, shows, but
  at least we're doing the right thing.

- Add a salt to HTTPS queries to defeat any caching.

- Add country metrics to HTTPS queries.

- Fix `get_radio_for_track` to use the right Spotify ID format.

- Fix a bug from the previous commit, where the playback position
  might not advance when hitting next and the autoplay context
  is loaded initially.
2022-10-01 23:01:17 +02:00
Roderick van Domburg bfb7d5689c
Retrieve autoplay contexts over HTTPS and fix repeat/prev/next
Repeat, previous and next used to start playback regardless of
the actual playback state. They now start playback only if we
were already playing.
2022-09-30 21:36:20 +02:00
Roderick van Domburg 6dc7a11b09
Re-introduce autoplay command-line option as an override 2022-09-28 22:59:03 +02:00
Roderick van Domburg d07f58e6df
Update crates 2022-09-28 22:17:55 +02:00
Roderick van Domburg cc1fb5a406
Update changelog 2022-09-28 22:17:43 +02:00
Roderick van Domburg eb1472c713
Various loading improvements
- Improve responsiveness by downloading the smallest possible chunk
  size when seeking or first loading.

- Improve download time and decrease CPU usage by downloading the
  largest possible chunk size as throughput allows, still allowing
  for reasonable seek responsiveness (~1 second).

- As a result, take refactoring opportunities: simplify prefetching
  logic, download threading, command sending, and some ergonomics.

- Fix disappearing controls in the Spotify mobile UI while loading.

- Fix handling of seek, pause, and play commands while loading.

- Fix download rate calculation (don't use the Mercury rate).

- Fix ping time calculation under lock contention.
2022-09-28 21:25:56 +02:00
Roderick van Domburg cce1b966cb
Merge pull request #1060 from JasonLG1979/fix-clippy-lint
Fix clippy lint
2022-09-23 07:52:52 +02:00
JasonLG1979 d446258be5 Fix clippy lint 2022-09-22 16:41:03 -05:00
Roderick van Domburg ccd501d22e
Merge pull request #1053 from JasonLG1979/connect-event
Major events overhaul
2022-09-22 21:43:09 +02:00
JasonLG1979 8545f361c4 Major Events Overhaul
Special thanks to @eladyn for all of their help and suggestions.

* Add all player events to `player_event_handler.rs`

* Move event handler code to `player_event_handler.rs`

* Add session events

* Clean up and de-noise events and event firing

* Added metadata support via a TrackChanged event

* Add `event_handler_example.py`

* Handle invalid track start positions by just starting the track from the beginning

* Add repeat support to `spirc.rs`

* Add `disconnect`, `set_position_ms` and `set_volume` to `spirc.rs`

* Set `PlayStatus` to the correct value when Player is loading to avoid blanking out the controls when `self.play_status` is `LoadingPlay` or `LoadingPause` in `spirc.rs`

* Handle attempts to play local files better by basically ignoring attempts to load them in `handle_remote_update` in `spirc.rs`

* Add an event worker thread that runs async to the main thread(s) but sync to itself to prevent potential data races for event consumers.

* Get rid of (probably harmless) `.unwrap()` in `main.rs`

* Ensure that events are emited in a logical order and at logical times

* Handle invalid and disappearing devices better

* Ignore SpircCommands unless we're active with the exception of ShutDown
2022-09-17 16:21:10 -05:00
eladyn 762f6d1a6f
strongly type ActivityPeriod (#1055)
switch fallibly to unsigned integers
2022-09-03 09:59:53 +02:00
Roderick van Domburg 5451d14972
Rate limit audio file streaming too 2022-09-01 22:35:03 +02:00
Roderick van Domburg 56b5f08a32
Sanitize rate limiting timeout 2022-08-31 21:08:11 +02:00
Roderick van Domburg 16dbade516
Try another access point if so instructed 2022-08-29 23:51:29 +02:00
Roderick van Domburg 6c2127bfcd
Implement rate limiting 2022-08-29 23:09:51 +02:00
Roderick van Domburg 49e885d158
Make hash cash challenges a bit more robust 2022-08-28 23:52:22 +02:00
Roderick van Domburg 10650712a7
Add mobile client IDs and improve hash cash logic 2022-08-26 22:29:00 +02:00
Roderick van Domburg 111c7781d2
Use actual OS and kernel versions 2022-08-26 21:14:43 +02:00
Roderick van Domburg 65e48864a5
Fix tracing of client token 2022-08-26 02:15:13 +02:00
Roderick van Domburg 7b19d4c1dd
Solve hash cash challenges (experimental) 2022-08-26 01:51:00 +02:00
Roderick van Domburg 42a665fb0d
Revert most of cdf84925ad 2022-08-25 21:01:39 +02:00
Roderick van Domburg dbf71c0dff
Move mostly harmless messages to debug level 2022-08-25 20:49:40 +02:00