github-mirrors/pyPLC
1
0
Fork 0
mirror of https://github.com/uhi22/pyPLC.git synced 2024-11-10 01:05:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docu: traces and issue description from SuperCharger

Browse source
This commit is contained in:
uhi22 2023-03-06 07:49:41 +01:00
parent f3e9210137
commit aab380706f
3 changed files with 3444 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
doc/bug_analysis.md
View file

@ -4,12 +4,15 @@
- In the SessionSetupResponse, the SuperCharger V3 correctly provides a sessionID, e.g. "06ef0071". - In the SessionSetupResponse, the SuperCharger V3 correctly provides a sessionID, e.g. "06ef0071".
- But we ignore this, and send in all next messages (starting with ServiceDiscoveryReq) the sessionID "deadbeefdeadbeef". - But we ignore this, and send in all next messages (starting with ServiceDiscoveryReq) the sessionID "deadbeefdeadbeef".
- The SuperCharger correctly complains with "ResponseCode": "FAILED_UnknownSession". - The SuperCharger correctly complains with "ResponseCode": "FAILED_UnknownSession".
- logs 2023-03-02_SuperCharger_CableCheck_error.pcapng and 2023-03-02_SuperCharger_CableCheck_error.decoded.txt
- observed with Software version v0.5-12-g23b1384, on 2023-03-02. - observed with Software version v0.5-12-g23b1384, on 2023-03-02.
- root cause: In main_commandlineinterface.c we check, whether the session ID has 16 characters, to represent 8 hex bytes. - root cause: In main_commandlineinterface.c we check, whether the session ID has 16 characters, to represent 8 hex bytes.
But the SuperCharger provides 8 characters, to present 4 bytes. Thats why the function useSessionIdFromCommandLine() But the SuperCharger provides 8 characters, to represent 4 bytes. That's why the function useSessionIdFromCommandLine()
operates with the default session ID "deadbeefdeadbeef". operates with the default session ID "deadbeefdeadbeef".
- solution: in function useSessionIdFromCommandLine(), also accept shorter session IDs. And in function init_dinMessageHeaderWithSessionID(), - solution: in function useSessionIdFromCommandLine(), also accept shorter session IDs. And in function init_dinMessageHeaderWithSessionID(),
use a dynamic length instead of the fixed length LEN_OF_SESSION_ID (=8). use a dynamic length instead of the fixed length LEN_OF_SESSION_ID (=8).
- implementation done with https://github.com/uhi22/OpenV2Gx/commit/9c08c19ce14446a316ed4059d6d5b5e07721fd9d
- to be tested.
## Issue 17: Welding detection fails ## Issue 17: Welding detection fails

3440
results/2023-03-02_SuperCharger_CableCheck_error.decoded.txt Normal file
View file

File diff suppressed because it is too large Load diff

BIN
results/2023-03-02_SuperCharger_CableCheck_error.pcapng Normal file
View file

Binary file not shown.