From 06898263f6ef8dc4294a8c7554023320c27b957c Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sat, 13 Oct 2018 08:28:15 -0400
Subject: [PATCH] key_manager: Use std::vector's insert() instead of std::copy
with a back_inserter
If the data is unconditionally being appended to the back of a
std::vector, we can just directly insert it there without the need to
insert all of the elements one-by-one with a std::back_inserter.
---
src/core/crypto/key_manager.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/core/crypto/key_manager.cpp b/src/core/crypto/key_manager.cpp
index 1d77fda79e..d2ce4f5bf5 100644
--- a/src/core/crypto/key_manager.cpp
+++ b/src/core/crypto/key_manager.cpp
@@ -881,9 +881,9 @@ void KeyManager::DeriveETicket(PartitionDataManager& data) {
"/system/save/80000000000000e2",
"rb+");
+ const auto blob2 = GetTicketblob(save2);
auto res = GetTicketblob(save1);
- const auto res2 = GetTicketblob(save2);
- std::copy(res2.begin(), res2.end(), std::back_inserter(res));
+ res.insert(res.end(), blob2.begin(), blob2.end());
for (const auto& raw : res) {
const auto pair = ParseTicket(raw, rsa_key);