From a49a5fa4d94e48e1f049365a8071ab5207ac5eee Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Mon, 18 Aug 2014 01:58:59 -0400
Subject: [PATCH] Common: Don't return a reference to a string when calling
GetName in symbols.cpp
Returning a copy of the string is what was likely meant to be done.
---
src/common/symbols.cpp | 2 +-
src/common/symbols.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/symbols.cpp b/src/common/symbols.cpp
index dcc9eeac5b..d61f4c0c6c 100644
--- a/src/common/symbols.cpp
+++ b/src/common/symbols.cpp
@@ -40,7 +40,7 @@ namespace Symbols
return symbol;
}
- const std::string& GetName(u32 _address)
+ const std::string GetName(u32 _address)
{
return GetSymbol(_address).name;
}
diff --git a/src/common/symbols.h b/src/common/symbols.h
index b767496547..e59bc5dd49 100644
--- a/src/common/symbols.h
+++ b/src/common/symbols.h
@@ -32,7 +32,7 @@ namespace Symbols
void Add(u32 _address, const std::string& _name, u32 _size, u32 _type);
TSymbol GetSymbol(u32 _address);
- const std::string& GetName(u32 _address);
+ const std::string GetName(u32 _address);
void Remove(u32 _address);
void Clear();
};