From 526e533e9029fdf1477bbbe6583a53673cfb5a36 Mon Sep 17 00:00:00 2001
From: ReinUsesLisp <reinuseslisp@airmail.cc>
Date: Mon, 2 Dec 2019 16:49:46 -0300
Subject: [PATCH 1/2] telemetry_session: Use temporary to avoid writing the
same enum
---
src/core/telemetry_session.cpp | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/src/core/telemetry_session.cpp b/src/core/telemetry_session.cpp
index 793d102d3e..62cfa4ae6c 100644
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@@ -165,24 +165,19 @@ void TelemetrySession::AddInitialInfo(Loader::AppLoader& app_loader) {
Telemetry::AppendOSInfo(field_collection);
// Log user configuration information
- AddField(Telemetry::FieldType::UserConfig, "Audio_SinkId", Settings::values.sink_id);
- AddField(Telemetry::FieldType::UserConfig, "Audio_EnableAudioStretching",
- Settings::values.enable_audio_stretching);
- AddField(Telemetry::FieldType::UserConfig, "Core_UseMultiCore",
- Settings::values.use_multi_core);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_ResolutionFactor",
- Settings::values.resolution_factor);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_UseFrameLimit",
- Settings::values.use_frame_limit);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_FrameLimit", Settings::values.frame_limit);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_UseDiskShaderCache",
- Settings::values.use_disk_shader_cache);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_UseAccurateGpuEmulation",
+ constexpr auto field_type = Telemetry::FieldType::UserConfig;
+ AddField(field_type, "Audio_SinkId", Settings::values.sink_id);
+ AddField(field_type, "Audio_EnableAudioStretching", Settings::values.enable_audio_stretching);
+ AddField(field_type, "Core_UseMultiCore", Settings::values.use_multi_core);
+ AddField(field_type, "Renderer_ResolutionFactor", Settings::values.resolution_factor);
+ AddField(field_type, "Renderer_UseFrameLimit", Settings::values.use_frame_limit);
+ AddField(field_type, "Renderer_FrameLimit", Settings::values.frame_limit);
+ AddField(field_type, "Renderer_UseDiskShaderCache", Settings::values.use_disk_shader_cache);
+ AddField(field_type, "Renderer_UseAccurateGpuEmulation",
Settings::values.use_accurate_gpu_emulation);
- AddField(Telemetry::FieldType::UserConfig, "Renderer_UseAsynchronousGpuEmulation",
+ AddField(field_type, "Renderer_UseAsynchronousGpuEmulation",
Settings::values.use_asynchronous_gpu_emulation);
- AddField(Telemetry::FieldType::UserConfig, "System_UseDockedMode",
- Settings::values.use_docked_mode);
+ AddField(field_type, "System_UseDockedMode", Settings::values.use_docked_mode);
}
bool TelemetrySession::SubmitTestcase() {
From be9f80ef5615f3e10140e950eb3122d830508fbf Mon Sep 17 00:00:00 2001
From: ReinUsesLisp <reinuseslisp@airmail.cc>
Date: Mon, 2 Dec 2019 16:50:36 -0300
Subject: [PATCH 2/2] telemetry_session: Report renderer backend
We only have OpenGL as an option for now. Hardcode the entry.
---
src/core/telemetry_session.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/core/telemetry_session.cpp b/src/core/telemetry_session.cpp
index 62cfa4ae6c..320e8ad739 100644
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@@ -169,6 +169,7 @@ void TelemetrySession::AddInitialInfo(Loader::AppLoader& app_loader) {
AddField(field_type, "Audio_SinkId", Settings::values.sink_id);
AddField(field_type, "Audio_EnableAudioStretching", Settings::values.enable_audio_stretching);
AddField(field_type, "Core_UseMultiCore", Settings::values.use_multi_core);
+ AddField(field_type, "Renderer_Backend", "OpenGL");
AddField(field_type, "Renderer_ResolutionFactor", Settings::values.resolution_factor);
AddField(field_type, "Renderer_UseFrameLimit", Settings::values.use_frame_limit);
AddField(field_type, "Renderer_FrameLimit", Settings::values.frame_limit);