From e9cf08c2411197860330f77650a9aaac586b9725 Mon Sep 17 00:00:00 2001
From: lat9nq <22451773+lat9nq@users.noreply.github.com>
Date: Fri, 30 Jul 2021 16:12:15 -0400
Subject: [PATCH] settings: Remove unnecessary std::move usages

Addresses review feedback.

Co-authored-by: Mai M. <mathew1800@gmail.com>
---
 src/common/settings.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/common/settings.h b/src/common/settings.h
index f54705a96e..4432b5ddde 100644
--- a/src/common/settings.h
+++ b/src/common/settings.h
@@ -170,11 +170,11 @@ public:
     void SetValue(const Type& value) override {
         Type temp;
         if (value < minimum) {
-            temp = std::move(minimum);
+            temp = minimum;
         } else if (value > maximum) {
-            temp = std::move(maximum);
+            temp = maximum;
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         std::swap(this->global, temp);
     }
@@ -188,11 +188,11 @@ public:
     const Type& operator=(const Type& value) override {
         Type temp;
         if (value < minimum) {
-            temp = std::move(minimum);
+            temp = minimum;
         } else if (value > maximum) {
-            temp = std::move(maximum);
+            temp = maximum;
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         std::swap(this->global, temp);
         return this->global;
@@ -344,11 +344,11 @@ public:
     void SetValue(const Type& value) override {
         Type temp;
         if (value < this->minimum) {
-            temp = std::move(this->minimum);
+            temp = this->minimum;
         } else if (value > this->maximum) {
-            temp = std::move(this->maximum);
+            temp = this->maximum;
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         if (this->use_global) {
             std::swap(this->global, temp);
@@ -367,11 +367,11 @@ public:
     const Type& operator=(const Type& value) override {
         Type temp;
         if (value < this->minimum) {
-            temp = std::move(this->minimum);
+            temp = this->minimum;
         } else if (value > this->maximum) {
-            temp = std::move(this->maximum);
+            temp = this->maximum;
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         if (this->use_global) {
             std::swap(this->global, temp);