github-mirrors/librespot
1
0
Fork 0
mirror of https://github.com/librespot-org/librespot.git synced 2024-12-18 17:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

Update default normalisation threshold

Browse source
This commit is contained in:
Roderick van Domburg 2021-09-02 22:04:30 +02:00
parent 1540636ccc
commit fe644bc0d7
No known key found for this signature in database
GPG key ID: FE2585E713F9F30A
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [playback] `alsamixer`: use `--device` name for `--mixer-card` unless specified otherwise - [playback] `alsamixer`: use `--device` name for `--mixer-card` unless specified otherwise
- [playback] `player`: consider errors in `sink.start`, `sink.stop` and `sink.write` fatal and `exit(1)` (breaking) - [playback] `player`: consider errors in `sink.start`, `sink.stop` and `sink.write` fatal and `exit(1)` (breaking)
- [playback] `player`: make `convert` and `decoder` public so you can implement your own `Sink` - [playback] `player`: make `convert` and `decoder` public so you can implement your own `Sink`
- [playback] Updated default normalisation threshold to -2 dBFS
### Deprecated ### Deprecated
- [connect] The `discovery` module was deprecated in favor of the `librespot-discovery` crate - [connect] The `discovery` module was deprecated in favor of the `librespot-discovery` crate

2
playback/src/config.rs
View file

@ -151,7 +151,7 @@ impl Default for PlayerConfig {
normalisation_type: NormalisationType::default(), normalisation_type: NormalisationType::default(),
normalisation_method: NormalisationMethod::default(), normalisation_method: NormalisationMethod::default(),
normalisation_pregain: 0.0, normalisation_pregain: 0.0,
normalisation_threshold: db_to_ratio(-1.0), normalisation_threshold: db_to_ratio(-2.0),
normalisation_attack: Duration::from_millis(5), normalisation_attack: Duration::from_millis(5),
normalisation_release: Duration::from_millis(100), normalisation_release: Duration::from_millis(100),
normalisation_knee: 1.0, normalisation_knee: 1.0,

2
src/main.rs
View file

@ -371,7 +371,7 @@ fn get_setup(args: &[String]) -> Setup {
.optopt( .optopt(
"", "",
NORMALISATION_THRESHOLD, NORMALISATION_THRESHOLD,
"Threshold (dBFS) to prevent clipping. Defaults to -1.0.", "Threshold (dBFS) to prevent clipping. Defaults to -2.0.",
"THRESHOLD", "THRESHOLD",
) )
.optopt( .optopt(